Filipchik_Kirill by filipchikkirill · Pull Request #30 · NikolaevArtem/Java_Core_June_2021

filipchikkirill · 2021-07-09T15:27:49Z

No description provided.

add StringBuilder remove case 5-9,0

rename MyApp.java -> Main.java

.gitignore

src/main/java/homework_1/Main.java

moved the creation of result String -> new method createStringResult removed check for missing args

…chik # Conflicts: # README.md # src/main/java/homework_1/Main.java

add color -> instead -> System.err the last commit deleted the main, returned it.

src/main/java/homework_1/Main.java

NikolaevArtem · 2021-09-21T08:15:12Z

src/main/java/homework_6/map_problems_generator/problem_impl/Wrapper.java

+
+public class Wrapper <T> implements Problem<T> {
+    private final Problem<T> innerProblem;
+    private final List<String> event = new ArrayList<>();


Good implementation for generating events!

NikolaevArtem · 2021-09-21T08:16:55Z

src/main/java/homework_7/Main.java

+
+    public static void main(String[] args) {
+        Kitten kitten = new Kitten("Murzik", 1);
+        KittenToCatFunction function = (k) -> new Cat(k.getName(), k.getAge() + 4);


Opt: you could add some more complicated logic to lambda, as example - converting one type to another (like, favourite toy to favourite color or smth like this)

NikolaevArtem · 2021-09-21T08:19:36Z

src/main/java/course_project/sea_battle/SeaBattleApp.java

+
+import course_project.sea_battle.controller.impl.GameControllerImpl;
+
+public class SeaBattleApp {


Opt: The field is quite narrow, i think it would look better with more space between cells by width

The game seems not working. I see you implemented PvP, but I play only for 1 Player. I don't see field for 2nd, don't see his name anywhere. Don't know how to shoot for 2nd.
And please introduce automatic ship placement, testing will be much easier

Good! Nice architecture, SOLID is followed. Code is pretty readable. Good Java Core and Java libraries usage.

To make better: interface could be refactored. Also check correct working of the game.

Also nice approach to testing, test cases are readable

Good, automatic ship placement! I found some minor issues with the interface:

When miss, there's no message to press enter to finish the turn. Actually, I didn't see this message anywhere... Confusing

In case i hit a ship, i need to press enter 2 times to be able to shoot again

No error message in case I already shot this cell

No message in case of destroyed ship

And please make field representation wider :)

The app now works correctly, I didn't find any bugs. And from the code perspective, the app looks great!

To make better: improve interface:)
The homework is approved

src/test/java/homework_4/singleton/SingletonTest.java

NikolaevArtem

Nice! The code needs small fixes, but except that - good job! The architecture is nice, and I see you exercised with inheritance/generics, which is cool. But remember that it's nice for learning purposes, but production code, at best, should be readable and simple first. Usually, when there's a choice between SOLID or readability/simplicity, I choose second. IMHO

NikolaevArtem · 2021-09-23T08:21:22Z

src/main/java/homework_4/custom_file_reader/CustomFileReader.java

+        try {
+            run1();
+        } catch (IOException e) {
+            e.printStackTrace();
+        }
+        try {
+            run2();
+        } catch (IOException e) {
+            e.printStackTrace();
+        }
+        try {
+            run3();
+        } catch (IOException e) {
+            e.printStackTrace();
+        }
+        try {
+            run4();
+        } catch (IOException e) {
+            e.printStackTrace();
+        }


Opt: these try-catch now are either not needed or not in right place...

NikolaevArtem

Approved!

filipchikkirill and others added 10 commits July 5, 2021 19:50

test from kirill

5d3db82

Gitignore update

cda7765

Initial commit v5

986bf6e

Moving and gitignore update

1d0a10b

add homework_lesson_2

a4c3c7b

add homework_lesson_2

b7db6c6

homework_lesson_2

dbfe254

add StringBuilder remove case 5-9,0

rename Homework_lesson_2 -> homework

52ae014

rename MyApp.java -> Main.java

refactor README.md

59d2dd8

Delete src/main/java/lesson_2 directory

42cd073

heptaber added readyForReview Sign for Artem to take a look and removed readyForReview Sign for Artem to take a look labels Jul 10, 2021

NikolaevArtem reviewed Jul 11, 2021

View reviewed changes

.gitignore Show resolved Hide resolved

NikolaevArtem reviewed Jul 11, 2021

View reviewed changes

src/main/java/homework_1/Main.java Outdated Show resolved Hide resolved

NikolaevArtem reviewed Jul 11, 2021

View reviewed changes

src/main/java/homework_1/Main.java Outdated Show resolved Hide resolved

NikolaevArtem reviewed Jul 11, 2021

View reviewed changes

src/main/java/homework_1/Main.java Outdated Show resolved Hide resolved

NikolaevArtem added the bug Code fix needed label Jul 11, 2021

NikolaevArtem changed the title ~~FilipchikKirill_homework~~ Filipchik_Kirill Jul 11, 2021

filipchikkirill added 2 commits July 12, 2021 08:41

fix bugs

aed8cb2

moved the creation of result String -> new method createStringResult removed check for missing args

Merge remote-tracking branch 'origin/master' into feature/KirillFilip…

1d4356c

…chik # Conflicts: # README.md # src/main/java/homework_1/Main.java

filipchikkirill added the readyForReview Sign for Artem to take a look label Jul 12, 2021

filipchikkirill added 2 commits July 12, 2021 17:28

fix bugs

ce8002f

add color -> instead -> System.err the last commit deleted the main, returned it.

fix bugs

0775258

NikolaevArtem reviewed Jul 13, 2021

View reviewed changes

src/main/java/homework_1/Main.java Outdated Show resolved Hide resolved

NikolaevArtem added HW_1 Good to go style Style fix needed and removed bug Code fix needed readyForReview Sign for Artem to take a look labels Jul 13, 2021

NikolaevArtem reviewed Sep 21, 2021

View reviewed changes

NikolaevArtem added the HW_7 label Sep 21, 2021

NikolaevArtem reviewed Sep 21, 2021

View reviewed changes

src/test/java/homework_4/singleton/SingletonTest.java Show resolved Hide resolved

NikolaevArtem added HW_5 bug Code fix needed labels Sep 21, 2021

Homework3 fix immutableclass

24408c3

NikolaevArtem suggested changes Sep 21, 2021

View reviewed changes

filipchikkirill added 11 commits September 21, 2021 11:57

Homework3 fix immutableclass

d579c63

Homework 6 add mutable

acb9a49

Homework 3 add mutable

7a97598

Homework fix SingletonTest

71662a4

course_project fix and add random fill field

193cfd9

course_project fix

5d67208

course_project fix

2be5bc1

course_project test

a2464ce

course_project test

d56c17e

course_project test

71f99ca

course_project test

d6cb9f7

filipchikkirill added the readyForReview Sign for Artem to take a look label Sep 21, 2021

hw_3 fix

a7c5231

NikolaevArtem added Course Project HW_3 and removed bug Code fix needed labels Sep 23, 2021

NikolaevArtem reviewed Sep 23, 2021

View reviewed changes

NikolaevArtem added HW_4 HW_6 and removed readyForReview Sign for Artem to take a look labels Sep 23, 2021

NikolaevArtem approved these changes Sep 23, 2021

View reviewed changes


		import course_project.sea_battle.controller.impl.GameControllerImpl;

		public class SeaBattleApp {

Conversation

filipchikkirill commented Jul 9, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

NikolaevArtem Sep 21, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

NikolaevArtem Sep 21, 2021

Choose a reason for hiding this comment

Uh oh!

NikolaevArtem Sep 21, 2021

Choose a reason for hiding this comment

Uh oh!

NikolaevArtem Sep 21, 2021

Choose a reason for hiding this comment

Uh oh!

NikolaevArtem Sep 21, 2021

Choose a reason for hiding this comment

Uh oh!

NikolaevArtem Sep 21, 2021

Choose a reason for hiding this comment

Uh oh!

NikolaevArtem Sep 23, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

NikolaevArtem left a comment

Choose a reason for hiding this comment

Uh oh!

NikolaevArtem Sep 23, 2021

Choose a reason for hiding this comment

Uh oh!

NikolaevArtem left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

NikolaevArtem Sep 21, 2021 •

edited

Loading